mapbox / mapbox/vtshaver

AsyncBaton may leak memory if an error occurs in shave setup

Open
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
44
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Per @springmeyer 's thoughts:

We should use the RAII pattern to ensure that AsyncBaton will not leak if an exception occurs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate AsyncBaton and the shave setup entry point, then trace what happens when setup raises an exception. Identify the existing tests for setup or error handling and use them to define done: AsyncBaton resources are released on the error path without changing successful setup behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.