Code consisitency/correctness around pointers
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 45
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
In regards to https://github.com/mapbox/vtquery/blob/5ffe8d7dac2851031b873ba088a27f1ae5add78a/src/vtquery.cpp#L26-L29
@alliecrevier ask:
[nitpick] Since T const& instead of const T& is the style used throughout this code file, it might make sense to use this style for pointers as well. So instead of const char* and static const char* you would use char const* and static char const* respectively. It looks weird to me but it's consistent!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/vtquery.cpp at lines 26-29, where the pointer declarations are referenced. Compare those declarations with the surrounding const-reference style, and consider the work done when the pointer syntax is consistent with the rest of the file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100