mapbox / mapbox/vtfx

orderby faster

Open
#30 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
4
Forks
2
PR merge metrics
No merged PRs in 30d

Description

dont do this whole bit twice:
https://github.com/mapbox/vtfx/blob/master/fx/orderby.js#L33-L45

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open fx/orderby.js and inspect lines 33-45 first, then trace the surrounding orderby entry point to understand why this section runs twice. The work is done when the repeated processing is consolidated without changing orderby behavior; the payload names no test file, so verify behavior using the repository's available checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.