v2 values of some type are ignored
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 52
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L96-L99
Values of type null_value_t, mapbox::util::recursive_wrapper<std::vector<value>>, and mapbox::util::recursive_wrapper<std::unordered_map<std::string, value>>> are simply ignored here. If this is correct, it needs to be documented.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at include/mapbox/vector_tile/builder.hpp lines 96-99 and inspect how the listed value types are handled. Determine whether ignoring null_value_t, recursive vector values, and recursive unordered-map values is intentional; then document the behavior if it is correct, or define the needed change and verify it with the existing test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100