IDs ignored
Open
Nobody has claimed this yet.
2.x
- Dominant language
- C++
- Stars
- 52
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
IDs < 0 and IDs not of type `int64_t` or `uint64_t` are simply ignored here:
https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L48-L59
Is this correct? If yes, I think it needs to be documented.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read include/mapbox/vector_tile/builder.hpp at lines 48-59 to verify how negative IDs and IDs not typed as int64_t or uint64_t are handled. Confirm whether this behavior is intentional, then document the supported and ignored ID types; done means the documented behavior matches the implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100