Take small objects by value
Open
Nobody has claimed this yet.
2.x
- Dominant language
- C++
- Stars
- 52
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
The functions in https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L72-L87 should probably take their parameters as values.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with include/mapbox/vector_tile/builder.hpp at lines 72-87 and inspect the parameter declarations for the functions mentioned. Compare their current forms with the issue's requested value semantics, then verify that the change preserves the library's existing behavior and builds successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100