mapbox / mapbox/vector-tile-spec

Typo in §4.4

Open
#148 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
1k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

The spec currently says:

> Feature attributes are encoded as pairs of integers in the `tag` field of a feature. [...] A feature MUST have an even number of `tag` fields. A feature `tag` field MUST NOT contain a key index or value index greater than or equal to the number of elements in the layer's `keys` or `values` set, respectively.

This should be `tags`, not `tag`.

I can do a quick PR to fix this but wanted to check first in case you thought it merited a 2.1.1 "bugfix" release (I don't think it does but YMMV).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open §4.4 of the specification and review the quoted feature-attribute wording. Change the singular `tag` references to `tags`, then verify that the section consistently uses the corrected term.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.