mapbox / mapbox/vector-tile-cs
VectorTileReader.getLayer(byte[] data) didn't check Zigzag when read ValueType.SInt
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 64
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Description
According to https://developers.google.com/protocol-buffers/docs/encoding
SInt should check Zigzag, is this an issue?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting VectorTileReader.getLayer(byte[] data), focusing on handling of ValueType.SInt, and compare it with the linked Protocol Buffers encoding documentation. Determine whether ZigZag decoding is required and whether the current behavior violates the specification; the issue is done when that question is resolved and the reader conforms to the documented encoding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100