mapbox / mapbox/vector-tile-base

Tests created differ, probably due to Dict order

Open
#9 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
57
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Every time I create the tests data using `create_test_data.py` I get a different `mvt` file. I believe this is because before Python 3.6 dictionaries are not ordered.

This is probably the problematic place:
https://github.com/mapbox/vector-tile-base/blob/vt3/tests/create_test_data.py#L137-L151

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read tests/create_test_data.py at lines 137-151 and inspect how the test data is assembled. Run the script more than once and compare the generated mvt files; done means repeated generation produces identical output across supported Python versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.