mapbox / mapbox/turf-swift

Enable automatic test discovery on Linux

Open
#146 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

  • #170 by @S2Ler — closed without merging
blocked build jira-sync-complete
Dominant language
Swift
Stars
271
Forks
65
PR merge metrics
No merged PRs in 30d

Description

As of apple/swift-package-manager#3053 and Swift 5.4, SPM now supports automatic test discovery on Linux. LinuxMain.swift is now deprecated. We should remove that file to take advantage of automatic test discovery, which will eliminate the need to maintain a list of tests by hand. (Looks like we somehow got away with not having an XCTestManifests.swift?)

Currently the Travis configuration for this repository installs Swift 5.0, so we’ll need to upgrade to 5.4; not sure if it’s supported by swiftenv:

https://github.com/mapbox/turf-swift/blob/62706f39e85ae37b2f7f6e5ac2d38371569266cc/.travis.yml#L7

/ref mapbox/mapbox-directions-swift#539
/cc @mapbox/navigation-ios

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with LinuxMain.swift and the Swift version entry in .travis.yml, then check the referenced Swift Package Manager change for automatic Linux test discovery. Done means the deprecated test-list file is removed, Travis uses Swift 5.4 or later, and the Linux tests are discovered automatically.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
build-system, ci-cd, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.