mapbox / mapbox/to-color

Increase the brightness bounds on blue

Open
#4 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
19
Forks
2
PR merge metrics
No merged PRs in 30d

Description

The brightness bounds for a blue hue like this is too dark and has poor legibilty:

Screen Shot 2021-03-04 at 11 37 22 AM Screen Shot 2021-03-04 at 11 38 51 AM

The bounds here https://github.com/mapbox/to-color/blob/d03ecd136a572dc81081c6b8b17454fac9b51e29/src/index.js#L182 should be adjusted by using a higher brightness values

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/index.js around line 182, where the brightness bounds for blue hues are defined. Compare the generated blue colors with the linked screenshots and verify that raising the brightness values improves legibility without disrupting the palette behavior; the issue is done when the adjusted bounds produce sufficiently readable blue output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
design
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.