mapbox / mapbox/tippecanoe

EOF message still prints with --quiet flag

Open
#961 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
3.1k
Forks
430
PR merge metrics
No merged PRs in 30d

Description

I have geojson point datasets that I'm converting to tilesets. I've been seeing the "Reached EOF without all containers being closed" message that is referenced in https://github.com/mapbox/tippecanoe/issues/191, and understand that the messages can be safely ignored in my context. However, I was still interested in quieting those messages (so that I could more easily find the messages I do need to pay attention to), and the --quiet flag doesn't seem to be doing the trick.

$ tippecanoe --minimum-zoom=10 --maximum-zoom=15 --quiet --no-feature-limit --read-parallel points.geojson -o points.mbtiles
points.geojson:580: Reached EOF without all containers being closed
In JSON object {"type":"FeatureCollection","name":"points","crs":{"type":"name","properties":{"name":"urn:ogc:def:crs:OGC:1.3:CRS84"}},"features":[]}
points.geojson:574: Found ] at top level

Is this expected behavior? Perhaps this is considered an error, and not a warning, and thus still prints? Ideally tippecanoe would recognize the case described be @e-n-f in #191

If your file actually does have one feature per line, and just has a FeatureCollection around them, then the messages are harmless and just refer to one thread reaching the end of its input with the FeatureCollection it started parsing

and not print the message at all, but having the --quiet flag actually work would be nice if it isn't possible to recognize circumstances where the message is harmless.

Version:

~ $ tippecanoe --version
tippecanoe v1.36.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported tippecanoe v1.36.0 command with the provided GeoJSON input and compare its output with and without --quiet. Trace where the EOF and top-level-container messages are emitted; done means quiet mode suppresses these messages without hiding relevant errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.