mapbox / mapbox/tippecanoe

Pull deps via mason packages

Open
#370 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
3.1k
Forks
430
PR merge metrics
No merged PRs in 30d

Description

Vendoring wagyu, variant, protozero, and geometry.hpp is suboptimal because:

- It is tempting to upgrade to head/unreleased versions
- It is easy for those versions to get out of date
- Upgrading results in large diffs unrelated to tippecanoe
- packaging scripts for tippecanoe then can't control the versions of deps

So while vendoring is convenient for development it has potential drawbacks for production stability.

Therefore we need to move away from vendoring and start pulling these deps via mason packages and pinning to released versions.

I'll tackle this in about 2 weeks when I am back from vacation.

/cc @artemp @flippmoke for visibility

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the vendored copies of wagyu, variant, protozero, and geometry.hpp, then inspect the packaging scripts that currently include them. Review how mason packages are pinned and verify that released dependency versions are used without unrelated diffs; confirm the packaging flow still controls those versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.