url.parse usage in tilelive.load is unpredicable on windows (remove?)
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 540
- Forks
- 106
- PR merge metrics
- No merged PRs in 30d
Description
The fallback to `url.parse` at https://github.com/mapbox/tilelive.js/blob/master/lib/tilelive.js#L81 fails hard on windows. Possible to consider removing this and requiring both protocol and pathname to be defined in a uri object?
At least on windows not passing uri as an object, but rather as a string leads to invalid and unpredicatable pathname results:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/tilelive.js at the fallback to url.parse around line 81. Reproduce the Windows behavior when a URI is passed as a string, then compare it with a URI object containing protocol and pathname. Done means the URI handling has predictable pathname results on Windows and the intended requirements for protocol and pathname are documented or enforced.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100