mapbox / mapbox/tilelive

global leaks

Open
#178 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
540
Forks
106
PR merge metrics
No merged PRs in 30d

Description

When I have mocha check for global leaks, it reports this:

```
Error: global leaks detected: tileliveProtocols, __core-js_shared__
```

Why does tilelive insert values into the global namespace? This is bad practice, and I've never seen mocha throw this error with any other node module.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the report with Mocha's global-leak check and inspect where tilelive or its dependencies create tileliveProtocols and __core-js_shared__. Determine whether those globals are intentional or unintended, then confirm the chosen fix by rerunning the same check without global-leak errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.