mapbox / mapbox/tilelive-vector
Can't override xml-provided source using the constructor opts
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 72
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
It's not possible (or if it is, not obvious how!) to override the source provided in the xml. This would be useful, for example, when using a style generated by tm2, but serving the vector tiles from a local cache on a non-networked device.
With the options passed to the constructor, the source is handled differently from other options, such as scale and format. The xml-provided values for these can be overridden in the constructor opts, but the reverse happens for source - the xml value overrides any source provided in the constructor.
https://github.com/mapbox/tilelive-vector/blob/4969f7af2c0490a7bb7ac80c95eddab49f3b5ed6/index.js#L80
I think if a source is provided in the constructor, then it should override the source in the xml, as per the behaviour of scale and format.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at index.js around line 80 and trace how constructor options are combined with the XML-provided source, comparing this with the handling of scale and format. Confirm that an explicitly provided constructor source takes precedence over the XML source, while existing behavior remains unchanged for other options.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100