mapbox / mapbox/tilelive-vector
Tests failing after numeral update
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 72
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
Refs https://github.com/adamwdraper/Numeral-js/pull/378
Seeing:
```
not ok 1233 should be equal
---
operator: equal
expected: 'Upload size should not exceed 750KB.'
actual: 'Upload size should not exceed 750KiB.'
at: Parse.error (/home/travis/build/mapbox/mapnik-swoop/node_modules/tilelive-vector/index.js:425:46)
```
This was caught by mapnik-swoop as it runs on a daily scrum: https://travis-ci.org/mapbox/mapnik-swoop/jobs/177731433#L1478
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the failing assertion reported by the mapnik-swoop Travis job and compare it with the Numeral.js pull request 378 referenced in the issue. Determine the intended wording for the upload-size error, then verify the related test passes without the KB/KiB mismatch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100