mapbox / mapbox/tilelive-omnivore
More responsive and detailed tests
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 8
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
This ticket serves as a reminder for the future...
Per chat with @rclark , tests should be a bit more verbose. This will come in handy when gut-checking major changes to the metadata object, and will be relevant in the coming months when we do a major overhaul of the metadata json.
- Add more detailed assertions for info returned and for expected mapnikXML generated.
- Remove the hardcoded fixtures, and create fixtures on the fly based on metadata returned from
mapnik-omnivore.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the existing tests, hardcoded fixtures, metadata handling, and mapnikXML generation mentioned in the issue. Review how metadata is returned by mapnik-omnivore, then expand assertions and generate fixtures from that metadata; done means the tests provide detailed coverage without hardcoded fixtures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100