Nested geoJson properties are copied by reference
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- JavaScript
- Stars
- 2.4k
- Forks
- 304
- PR merge metrics
- No merged PRs in 30d
Description
When cloning a cluster in _map the assign function only shallow clones an object, copying sub-objects or arrays by reference. This can result in mutations to the original object when the accumulator is mutated in reduce.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The relevant entry point is _map, where assign shallow-clones objects before the accumulator is mutated in reduce. Reproduce the nested-object or array case and verify that changing the accumulator no longer changes the original object.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100