mapbox / mapbox/supercluster

typeof "point_count_abbreviated" of a cluster

Open
#200 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
2.4k
Forks
304
PR merge metrics
No merged PRs in 30d

Description

Hi!

I recently started to get familiar with the package. Thanks for the awesome work so far!

I've noticed one unexpected behavior so far which is having the point_count_abbreviated property with two different types, number and string. It was unexpected because we already have `point_count` property which is always number and well the format of long number's `point_count_abbreviated` property should always be string anyhow. So I would suggest to have this `point_count_abbreviated` field as string by default.

What would be thoughts on this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by tracing where the cluster's point_count_abbreviated property is constructed and inspect existing tests for cluster output; done means the property consistently has string type, with coverage for both short and long point counts.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.