mapbox / mapbox/simplespec-to-gl-style
Use id instead of custom _id property
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 34
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
The GeoJSON specification provides for Feature and FeatureCollection objects to have an [`id`](https://tools.ietf.org/html/rfc7946#section-3.2) member alongside (but not within) the `properties` member. This library currently adds an `_id` member to the `properties` object, but we should transition it over to the standard `id` member. The filter would compare `$id` instead of `_id`.
/cc @bsudekum
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating where the library adds `_id` to GeoJSON properties and where the filter compares `_id`. Trace Feature and FeatureCollection output and the filter path, then verify that the standard top-level `id` member and `$id` comparison are used consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100