mapbox / mapbox/shp-write

Version of shpwrite.js on unpkg is out of date

Open
#118 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
321
Forks
195
PR merge metrics
No merged PRs in 30d

Description

The version of shpwrite.js on unpkg is out of date.

For example, https://unpkg.com/@mapbox/shp-write@latest/shpwrite.js (which, at time of writing, redirects to version 0.4.3 at https://unpkg.com/@mapbox/shp-write@0.4.3/shpwrite.js) does not contain the latest code. If you search there for the `justType` function it reads as:

```js
function justType(type, TYPE) {
return function (gj) {
var oftype = gj.features.filter(isType(type));
return {
geometries: oftype.map(justCoords),
properties: oftype.map(justProps),
type: TYPE,
};
};
}
```

As opposed to what's in [geojson.js](https://github.com/mapbox/shp-write/blob/v0.4.3/src/geojson.js) for version 0.4.3:

https://github.com/mapbox/shp-write/blob/48a0fe72c09f74f6256ac8d4177af272d01317c3/src/geojson.js#L13-L22

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the published shpwrite.js at the unpkg URL with src/geojson.js at the referenced v0.4.3 commit, focusing on the justType function. Start by checking how this version is packaged and published, then verify that the unpkg artifact contains the latest source after release.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
release
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.