mapbox / mapbox/robosat

Refactor robosat to be a proper library with utility tools on top of it

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.1k
Forks
385
PR merge metrics
No merged PRs in 30d

Description

At the moment we almost have a clean split in place: we have command line utilities in robosat.tools and everything else split off of it. What we should do is making sure all functionality is in packages and not in robosat.tools: all the command line tools should do is parse command line arguments and then delegate to robosat library functions.

Here are an examples where this is not the case currently:

  • The convert tool has the functionality for splitting off masks
  • And the masks tool has the functionality to do the soft-voting

These features should be encapsulated in robosat packages and then only getting called in the tools.


Why are we doing this? We want to create a Python robosat package folks can install and re-use. Think:

pip install robosat
from robosat.ensemble import softvote
....

Our tools should have a dependency on this robosat package; but not the other way around.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the robosat.tools command-line utilities, especially convert and masks, and identify functionality that belongs in robosat packages. Move mask splitting and soft-voting behind reusable library entry points, then verify that the tools only parse arguments and delegate to them. Done means the robosat package can be installed and imported independently of the tools.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.