mapbox / mapbox/robosat

Move simplification to `rs merge` pipeline step

Open
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.1k
Forks
385
PR merge metrics
No merged PRs in 30d

Description

Currently in rs feature we extract polygons and simplify them. Then in rs merge we buffer, then union, then unbuffer for merging shapes across tile boundaries. This leads to polygons that are no longer simplified.

We should investigate not simplifying in rs feature. Instead merge un-simplified geometries, then simplify in rs merge at the end of the pipeline.

Tasks:

  • Remove simplification in rs feature
  • Implement simplification in rs merge after merging shapes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the rs feature and rs merge entry points and locate where polygon simplification, buffering, union, and unbuffering occur. Remove the feature-stage simplification, then apply simplification after merging shapes in rs merge; done means merged geometries remain simplified without losing cross-tile shapes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.