mapbox / mapbox/rio-cloudmask

Fails when there are no clear sky land pixels

Open
#8 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
55
Forks
12
PR merge metrics
No merged PRs in 30d

Description

Proximate failure: the `temp_land` function returns a single `nan` which prevents the `tlow, thigh = temp_land(pcps, water, tirs1)` from unpacking (expects two variables)

But the bigger question is, what should the algorithm do in this case? It's not well defined in the publication so I'll have to dig into the implemetation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing the `temp_land` function and its `tlow, thigh = temp_land(pcps, water, tirs1)` caller, then compare the implementation with the publication for the no-clear-sky-land-pixels case. Done should include a defined algorithm outcome and coverage for the single-`nan` failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.