Error in brightness test
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 55
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
I found a small typo in the algorithm.
According to the paper, it is band 5 that is used for brightness test, i.e. swir1 and not nir as coded in rio-cloudmask. This messes a lot of things over water.
Many thanks for the clean code style!
Thomas
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for the brightness test and the use of nir, then compare that logic with the referenced paper. Update the test to use band 5, swir1, and verify that the brightness calculation behaves correctly over water.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100