Implementing the depreciated start and end groups types
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 881
- Forks
- 113
- PR merge metrics
- No merged PRs in 30d
Description
As indicated here https://developers.google.com/protocol-buffers/docs/encoding The wire types of 3 and 4 (start and end groups) are "depreciated" ... but unfortunately they still exist on some protobuf packets floating around.
This could be easily resolved by adding these types and then update skip to include them (skipping zero bytes):
` else if (type === Pbf.StartGroup) this.pos += 0;`
` else if (type === Pbf.EndGroup) this.pos += 0;`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the JavaScript wire-type constants and the skip routine referenced in the issue. Add support for start and end groups so packets using wire types 3 and 4 are skipped without advancing over payload bytes, then verify the existing behavior around skip.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100