mapbox / mapbox/osm-wayback

Timestamp Mismatch

Open
#19 0 comments 0 reactions 1 assignee View on GitHub

@jenningsanderson is already working on this.

Since Aug 9, 2017.

enhancement
Dominant language
C++
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The `@timestamp` field created by `minjur` is in seconds while OSM timestamps are strings.

Propose changing current `@timestamp` in current history objects to seconds. Human readable format is good for debugging, perhaps include a flag to keep a `@created_at` or `@datestamp` field?

```
{
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [
-122.2519108,
37.7453841
]
},
"properties": {
"@id": 53064457,
"@type": "node",
"@version": 4,
"@changeset": 3523505,
"@uid": 28775,
"@user": "StellanL",
"@timestamp": 1262471316,
"highway": "turning_circle",
"@history": [
{
"@timestamp": "2007-09-17T05:09:27Z",
"@visible": true,
"@user": "DaveHansenTiger",
"@uid": 7168,
"@changeset": 446628,
"@version": 1,
"@new_tags": {
"source": "tiger_import_dch_v0.6_20070809",
"tiger:tlid": "125005627:125038258",
"tiger:county": "Alameda, CA",
"tiger:upload_uuid": "bulk_upload.pl-9d5e179e-e488-4300-b71d-b0a82eacb273"
}
},
{
"@timestamp": "2008-05-02T00:39:37Z",
"@visible": true,
"@user": "quarl",
"@uid": 36344,
"@changeset": 307804,
"@version": 2
},
{
"@timestamp": "2010-01-02T22:28:36Z",
"@visible": true,
"@user": "StellanL",
"@uid": 28775,
"@changeset": 3523505,
"@version": 4,
"@del_tags": {
"source": "tiger_import_dch_v0.6_20070809",
"tiger:county": "Alameda, CA",
"tiger:tlid": "125005627:125038258",
"tiger:upload_uuid": "bulk_upload.pl-9d5e179e-e488-4300-b71d-b0a82eacb273"
},
"@new_tags": {
"highway": "turning_circle"
}
}
]
}
}
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.