mapbox / mapbox/osm-comments-parser
Tests silently failing
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 5
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
The current npm script gives a thumbs up even if some tests fail.
So we get a green light on most of the PRs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the repository's npm scripts and run the current test command to reproduce the successful result despite a failing test. Update the test command so failures produce a nonzero status, then verify that the command reports failure when an existing test fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100