osm-bright does not render administrative boundaries when data is imported via osm2pgsql)
Nobody has claimed this yet.
- Dominant language
- CartoCSS
- Stars
- 703
- Forks
- 222
- PR merge metrics
- No merged PRs in 30d
Description
I have been attempting to render cities' boundaries (referred as 'administrative boundaries' in osm) in tilemill (using the osm-bright stylesheet) using the default style of osm2pgsql and osm-bright.
osm2pgsql's default stylesheet treats the tag admin-level with the data type 'text' (see https://github.com/openstreetmap/osm2pgsql/blob/master/default.style#L35 )
Currently, osm-bright's base.mss treats the admin-level field as a numerical, 'float' flavor. When a user is importing osm data into osm-bright via osm2pgsql, no administrative boundaries will be displayed.
To fix this, simply change admin[admin_level=2] to admin[admin_level='2'] in base.mss
Pull request was removed because there still may be conflicts with imposm.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with osm-bright/base.mss and compare the admin_level filter with osm2pgsql's default.style. Check the issue's noted imposm compatibility concern before testing the proposed filter form. Done means administrative boundaries render for osm2pgsql imports without breaking the other import path.
Written by the indexing model from the issue text.
Assessment
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100