mapbox / mapbox/osm-bright

Missing a few object-types in OSMBright

Open
#117 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CartoCSS
Stars
703
Forks
222
PR merge metrics
No merged PRs in 30d

Description

I use OSMBright as a basis for a tileserver to produce "watermaps" for the Netherlands but I'm missing some "water-related" objects in the resulting tiles that I get from my tileserver.
I figured out that they can be found in OSM with: **man_made=breakwater** and **waterway=dam**. Both to represented in the result as "landlike" objects, as they are "obstructions" in the water and are raising above the watersurface.
Could those two "object-types" be added to OSMBright in a future version? Maybe there are "related" object-types that spring to mind for more experienced OSM'ers.... but these are two that would be very nice to have for in my project.
If someone could provide me with some directions in how to do it myself in the future, I'm more then willing to do so but I'm very "green" in this area.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the OSMBright style rules that classify water and landlike objects, then trace how OSM tags are assigned to rendered layers. Add support for man_made=breakwater and waterway=dam as landlike obstructions, and verify that both appear correctly in the generated tiles.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.