binary host mirror override does not work for module_names with multiple dashes
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
The binary host mirror environment variable does not work for packages with binary.module_name values containing more than one dash because it does not use replaceAll here: https://github.com/mapbox/node-pre-gyp/blob/master/lib/util/versioning.js#L315. I encountered this trying to use the binary host mirror override with https://github.com/confluentinc/confluent-kafka-javascript/blob/master/package.json#L19.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/util/versioning.js around line 315 and compare the binary host mirror environment-variable handling with the reported module_name case in confluent-kafka-javascript/package.json. Confirm that a module name containing multiple dashes produces the expected mirror override, then run the repository's relevant tests or test suite to verify the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100