mapbox / mapbox/node-pre-gyp

DEP0155 and DEP0156 warnings during build

Open
#876 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

I found some problems with some of these libraries, I was getting warnings from node during builds, and after some time troubleshooting I found out that node-fetch@2.7 uses whatwg-url@5.0 which is an obsolete dependency that uses deprecated syntax.

image image

image

I think it's necessary to update the version of node-fetch

https://github.com/mapbox/node-pre-gyp/blob/3200e1c803176d67b9c89f6d918ed6bcb618820d/package.json#L29

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with package.json at the linked dependency entry around line 29 and inspect the node-fetch version and its dependency tree. Reproduce the build warnings, update the dependency as appropriate, and confirm that the build no longer emits DEP0155 or DEP0156 warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.