mapbox / mapbox/node-pre-gyp

split binary download logic into standalone module

Open
#81 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

First, thanks for your work on this!

I'm currently using this module to download a binary that is not a node addon. As such, there is no build step to fall back to, and there is no `.node` binding to deal with after the tarball has been extracted. It seems to me that the downloading portion of this module could live in a new module called something like `node-download-binary`.

Thoughts?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the current binary download and extraction logic in the module, focusing on where it assumes a Node addon, a build fallback, or a .node binding. Done means the download portion can stand alone for non-addon binaries without retaining those addon-specific assumptions.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.