Option ---cafile for install doesn't work
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
Hi,
I've tried to use --cafile option to pass certificate but it didn't take any effect. I've looked at the code of install.js and discover that:
if (opts.cafile) {
try {
requestOpts.ca = fs.readFileSync(opts.cafile);
} catch (e) {
return callback(e);
}
} else if (opts.ca) {
requestOpts.ca = opts.ca;
}
But there is no any usage of requestOpts. :-( I suppose here we need to create a https.Agent with appropriate parameters. Also it would be great to pass rejectUnauthorized: false as an option from command-line.
Thanks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in install.js at the shown cafile and ca handling, then trace where requestOpts is passed or discarded. Determine how HTTPS requests are configured and how command-line options reach that path. Done means --cafile affects certificate validation during install, with the requested rejectUnauthorized behavior clarified and covered by the existing relevant checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100