mapbox / mapbox/node-pre-gyp

The library captures --dir argv parameter

Open
#611 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

I have a Node script which uses `--dir` command line argument for its own purposes. The script uses bcrypt, and brcypt uses @mapbox/node-pre-gyp. So long story short, when running `node my-script.js --dir=abc`, @mapbox/node-pre-gyp starts failing saying something like "can't open the file .../abc.../..." when dealing with bcrypt binary file. I think the library uses process.argv somewhere and treats `--dir` flag from there somehow.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report with my-script.js and `node my-script.js --dir=abc`, then inspect the library's process.argv handling and the @mapbox/node-pre-gyp entry point. No repository file or test is named in the issue; done means application-owned `--dir` arguments no longer change binary lookup or cause the bcrypt load to fail.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.