mapbox / mapbox/node-pre-gyp

Unable to build my addons for node v12 , using node-pre-gyp

Open
#485 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using node-pre-gyp@0.14.0
node-pre-gyp info using node@12.13.1 | linux | x64
gyp info it worked if it ends with ok
gyp info using node-gyp@6.0.1
gyp info using node@12.13.1 | linux | x64
gyp info ok
gyp info it worked if it ends with ok
gyp info using node-gyp@6.0.1
gyp info using node@12.13.1 | linux | x64
gyp info find Python using Python version 3.5.2 found at "/usr/bin/python3"
gyp info spawn /usr/bin/python3

Errors : i am not able to understand

  1. ../src/cpu_profiler.cc:37:42: error: no matching function for call to ‘v8::Value::ToBoolean()’
    bool recsamples = info[1]->ToBoolean()->Value();

  2. note: candidate: v8::MaybeLocalv8::Boolean v8::Value::ToBoolean(v8::Localv8::Context) const
    V8_WARN_UNUSED_RESULT MaybeLocal ToBoolean(

can anyone please help me out

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ../src/cpu_profiler.cc at line 37 and compare the node-pre-gyp/node-gyp setup in the report with the Node 12.13.1 and V8 API error. Reproduce the build using node-pre-gyp 0.14.0, node-gyp 6.0.1, Node 12.13.1, and Python 3.5.2; done means the addon builds without the reported ToBoolean error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, javascript, node.js
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.