Node v8.1.0 recognized as NAPI v1
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
Hi,
I tested my package on a fresh Ubuntu 18.04 installed, with Node v8.1.0. According to [this matrix](https://nodejs.org/api/n-api.html#n_api_n_api_version_matrix), it uses NAPI v2 and sure enough if I compile it, it works fine (my package doesn't compile on NAPI v1). However, on that same machine when it tries to download a binary, it attempts to download a NAPI v1 binary, which I don't have and according to the matrix is incorrect. It should be looking for NAPI v2.
Thanks,
Gustav
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the N-API version matrix linked in the issue and trace the binary-download path that determines the ABI for Node v8.1.0. Compare the detected version with the expected NAPI v2 value; done means this environment requests the NAPI v2 binary instead of NAPI v1.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, javascript, node.js
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100