mapbox / mapbox/node-pre-gyp

Error: Completion callback never invoked w/v0.11.0 + request

Open
#433 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

I'm opening a new issue based on @springmeyer's [comment](https://github.com/mapbox/node-pre-gyp/issues/367#issuecomment-405969068) on #367.

Here's what I'm seeing when issuing an `npm rebuild`:

```
$ npm rebuild --update-binary --target_arch=x64 --target_platform=linux
node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp ERR! Completion callback never invoked!
node-pre-gyp ERR! System Darwin 18.2.0
node-pre-gyp ERR! command "/private/var/tmp/_bazel_rohansingh/649b503783f1008804e854e38f7f4c52/external/nodejs/bin/nodejs/bin/node" "/private/var/tmp/_bazel_rohansingh/649b503783f1008804e854e38f7f4c52/execroot/hustle/bazel-out/darwin-fastbuild/genfiles/backend/npm_backend/node_modules/bcrypt/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /private/var/tmp/_bazel_rohansingh/649b503783f1008804e854e38f7f4c52/execroot/hustle/bazel-out/darwin-fastbuild/genfiles/backend/npm_backend/node_modules/bcrypt
node-pre-gyp ERR! node -v v10.13.0
node-pre-gyp ERR! node-pre-gyp -v v0.11.0
node-pre-gyp ERR! This is a bug in `node-pre-gyp`.
node-pre-gyp ERR! Try to update node-pre-gyp and file an issue if it does not help:
node-pre-gyp ERR!
npm ERR! code ELIFECYCLE
npm ERR! errno 6
npm ERR! bcrypt@3.0.2 install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 6
npm ERR!
npm ERR! Failed at the bcrypt@3.0.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
```

This is actually running in [Bazel](https://bazel.build), but I've disabled Bazel's sandboxing and checked that tools like `curl` work in the same context.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the `npm rebuild --update-binary --target_arch=x64 --target_platform=linux` command with node-pre-gyp v0.11.0 and the request-based download path shown in the log. Trace where the completion callback should be invoked; done means the rebuild completes without `Completion callback never invoked!` or the resulting lifecycle failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.