mapbox / mapbox/node-pre-gyp

--target should support Node ABI in addition to version

Open
#401 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

Calling `node-pre-gyp` with the `--target` parameter currently performs a lookup of Node version and matches that to a particular Node ABI using an internal lookup map. Over in https://github.com/mapbox/cmake-node-module, we're not concerned with Node versions, we only care about the ABI so it'd be cool to be able to pass the ABI version directly.

While we're at it, we could also add support for specifying the N-API ABI with `--target`.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the --target CLI handling and the internal lookup map that converts Node versions to ABIs. Determine how direct Node ABI and N-API ABI values should be distinguished, then verify that both forms work through the command-line path.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.