mapbox / mapbox/node-pre-gyp

Proxy support regressed

Open
#400 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

It looks like the move to needle regressed proxy support for some users: https://github.com/mapbox/node-sqlite3/issues/1010.

I don't have the time or ability to debug this. Anyone familiar with proxies have the bandwidth to take a look? Seems like the options would be to use needles support for passing a custom agent or revert back to request.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked node-sqlite3 issue and locating where node-pre-gyp moved to needle. Compare needle's custom-agent support with the previous request behavior, then determine whether proxy support can be restored through an agent or by reverting to request. Done means proxy users no longer experience the reported regression.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.