mapbox / mapbox/node-pre-gyp

Improved warning message for "binaries not found"

Open
#397 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

The current message is:

```
Pre-built binaries not found for sqlite3@4.0.1 and node@6.14.3 (node-v48 ABI, unknown) (falling back to source compile with node-gyp
```

Improvements needed are:

- the `unknown` is for `{libc}`. It should only display if the module uses `{libc}` versioning
- we talk about node ABI, but what about if a module uses N-API?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the code that formats the “Pre-built binaries not found” warning and inspect how ABI and libc values are selected. Verify the message handles libc only when relevant and accounts for N-API as well as Node ABI; no file or test is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.