Support variables in module_name property
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
In mapbox-gl-native, we'd like to use `"module_name": "mbgl-node.abi-{node_abi}"`, to integrate with [`@mapbox/cmake-node-module`](https://github.com/mapbox/cmake-node-module), which provides cross-compilation for multiple node ABIs and therefore includes the ABI version in the module name.
Refs https://github.com/mapbox/mapbox-gl-native/pull/12159.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by tracing how node-pre-gyp reads and uses the module_name property, then review the referenced @mapbox/cmake-node-module integration and its ABI naming convention. Done means module_name can express the requested node_abi value and existing behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- build-system, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100