proxy environement variables are not resolved correctly
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
The logic to figure out the proxy from the environment variables is currently incorrect. It should look for both HTTPS_PROXY and HTTP_PROXY instead of assumming that HTTP_PROXY might be an http (non "s") url.
https://github.com/mapbox/node-pre-gyp/blob/master/lib/install.js#L49-L55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting lib/install.js at lines 49-55, where the proxy is resolved from environment variables. Check the behavior with both HTTPS_PROXY and HTTP_PROXY set, and verify that the selected proxy is based on the appropriate variable rather than assuming HTTP_PROXY contains an HTTP URL. Done means both variables are handled correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100