Pre-release target flag is not supported
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
I am trying to build a native addon for electron using this command:
```
HOME=~/.electron-gyp node-pre-gyp rebuild --target=1.8.2-beta.3 --arch=x64 --dist-url=https://atom.io/download/electron
```
It throws the following error:
```
node-pre-gyp ERR! UNCAUGHT EXCEPTION
node-pre-gyp ERR! stack Error: Unknown target version: 1.8.2-beta.3
node-pre-gyp ERR! stack at get_runtime_abi (/Users/adamb/repos/status-nodejs/node_modules/node-pre-gyp/lib/util/versioning.js:97:27)
node-pre-gyp ERR! stack at Object.module.exports.evaluate (/Users/adamb/repos/status-nodejs/node_modules/node-pre-gyp/lib/util/versioning.js:293:19)
node-pre-gyp ERR! stack at clean (/Users/adamb/repos/status-nodejs/node_modules/node-pre-gyp/lib/clean.js:14:27)
node-pre-gyp ERR! stack at Object.self.commands.(anonymous function) [as clean] (/Users/adamb/repos/status-nodejs/node_modules/node-pre-gyp/lib/node-pre-gyp.js:50:37)
node-pre-gyp ERR! stack at run (/Users/adamb/repos/status-nodejs/node_modules/node-pre-gyp/bin/node-pre-gyp:82:30)
node-pre-gyp ERR! stack at _combinedTickCallback (internal/process/next_tick.js:131:7)
node-pre-gyp ERR! stack at process._tickCallback (internal/process/next_tick.js:180:9)
node-pre-gyp ERR! stack at Function.Module.runMain (module.js:684:11)
node-pre-gyp ERR! stack at startup (bootstrap_node.js:191:16)
node-pre-gyp ERR! stack at bootstrap_node.js:613:3
```
This target should be perfectly valid as it works with `node-gyp` just fine.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/util/versioning.js, especially get_runtime_abi around line 97 and evaluate around line 293, using the reported node-pre-gyp command with target 1.8.2-beta.3 as the reproduction. Compare how node-gyp accepts this target and verify that the pre-release target is handled without the Unknown target version error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100