mapbox / mapbox/node-pre-gyp

The error when failing to install a binary from remote is less helpful than it should be

Open
#330 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

The print_fallback_error function tries here to output err.statusCode to indicate why the operation failed. However, that error comes from the place_binary function, which only appears to set a status code in the case of network errors, resulting in an unhelpful undefined error in other situations as reported in grpc/grpc#13241.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/install.js at place_binary and print_fallback_error, following how failures produce err.statusCode. Reproduce or trace a non-network remote installation failure and make the fallback error identify the actual failure instead of showing undefined.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.