mapbox / mapbox/node-pre-gyp

print_fallback_error - Use log.warn instead log.error

Open
#323 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

Since it is fallback maybe it would be better to use logger.warn

https://github.com/mapbox/node-pre-gyp/blob/5b76d52e26f5a8e2ac7f2fe90c2ec32006ba1a65/lib/install.js#L138

Some CI tools like TeamCity will assume that as failed build

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open lib/install.js around line 138 and inspect print_fallback_error and its logging call. Change the fallback severity from error to warn, then verify that the fallback no longer emits an error-level message in the relevant CI behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.