mapbox / mapbox/node-pre-gyp

Drop request dependency

Open
#198 14 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Description

Packages depend on `node-pre-gyp` as a deep dependency, not as a top level dependency. Deep dependencies should be lightweight and shouldn't include bloatware. While the `request` library has a lot of offer, it ships a shitton of bloatware on install, Node provides [`http.request`](https://nodejs.org/api/http.html#http_http_request_options_callback) and [`https.request`](https://nodejs.org/api/https.html#https_https_request_options_callback) we should be using that

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing node-pre-gyp's use of the request dependency and the Node http.request and https.request entry points named in the issue. Confirm how the package currently performs those requests and identify the relevant existing checks before replacing the dependency. Done means request is no longer pulled in while the package's request behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.