module_path not working as expected (with github as host)
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
Hello, I'm not sure if this is an issue, I'm trying to use node-pre-gyp to download pre-built binary from github host.
npm install mymodule will download the pre-built binary from github host, but the module downloaded is not in the right path.
For below config, I expect downloaded binary path to be ./build/mymodule.node. But the actual binary path is .build (build is not dir, it's the binary file)
Please advise, thanks!
"binary": {
"module_name": "mymodule",
"module_path": "./build/",
"host": "https://github.com",
"package_name": "{platform}-{arch}.tar.gz",
"remote_path": "./myproject/dist/raw/master/v{version}/"
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the binary configuration handling for the GitHub host, focusing on how module_path is interpreted during npm install. Reproduce the installation with the provided configuration and verify that the downloaded binary is placed at ./build/mymodule.node rather than being written as .build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, javascript, nodejs
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100