Do not throw exception for unsupported version when building anyway
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 271
- Avg merge
- 23h 40m
- Merged PRs (30d)
- 2
Description
When falling back to building from source, it would be useful if the version check didn't blow up and just passed through. This seems to cause a lot of trouble for things like atom-shell (electron) which it seems isn't supported as well as anything else new that appears. Would that be giving the build the best possible chance to succeed even if node-pre-gyp isn't caught up to the v8 flavor of the month?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing node-pre-gyp's version check when it falls back to building from source, using the unsupported-version behavior described here. Review the existing comment discussion, then verify that an unsupported version passes through without throwing while the source build still gets a chance to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, javascript, nodejs
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100